Re: Remove distprep - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Remove distprep
Date
Msg-id 20230714082443.beuo3bgbfmslm5co@alvherre.pgsql
Whole thread Raw
In response to Re: Remove distprep  (Peter Eisentraut <peter@eisentraut.org>)
List pgsql-hackers
On 2023-Jul-14, Peter Eisentraut wrote:

> diff --git a/src/backend/parser/Makefile b/src/backend/parser/Makefile
> index 9f1c4022bb..3d33b082f2 100644
> --- a/src/backend/parser/Makefile
> +++ b/src/backend/parser/Makefile
> @@ -64,8 +64,8 @@ scan.c: FLEX_FIX_WARNING=yes
>  # Force these dependencies to be known even without dependency info built:
>  gram.o scan.o parser.o: gram.h
>  
> -
> -# gram.c, gram.h, and scan.c are in the distribution tarball, so they
> -# are not cleaned here.
> -clean distclean maintainer-clean:
> +clean:
> +    rm -f parser/gram.c \
> +          parser/gram.h \
> +          parser/scan.c
>      rm -f lex.backup

Hmm, this hunk and the equivalents in src/backend/bootstrap and
src/backend/replication are wrong: you moved the rule from the parent
directory's makefile to the directory where the files reside, but didn't
remove the directory name from the command arguments, so the files
aren't actually deleted.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El destino baraja y nosotros jugamos" (A. Schopenhauer)



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Next
From: Daniel Gustafsson
Date:
Subject: Re: 16beta2 SQL parser: different defaults on absent_on_null