Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb
Date
Msg-id 20230629210528.GA2055033@nathanxps13
Whole thread Raw
In response to Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
On Wed, Jun 28, 2023 at 10:24:09PM -0700, Nathan Bossart wrote:
> On Wed, Jun 28, 2023 at 09:20:03PM -0700, Gurjeet Singh wrote:
>> Nitpicking:  The patch seems to have Windows line endings, which
>> explains why my `patch` complained so loudly.
>> 
>> $ patch -p1 < v1-0001-harmonize-....patch
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> patching file doc/src/sgml/ref/reindexdb.sgml
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> patching file doc/src/sgml/ref/vacuumdb.sgml
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> patching file src/bin/scripts/clusterdb.c
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> patching file src/bin/scripts/reindexdb.c
>> 
>> $ file v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch
>> v1-0001-harmonize-....patch: unified diff output text, ASCII text,
>> with CRLF line terminators
> 
> Huh.  I didn't write it on a Windows machine.  I'll look into it.

I couldn't reproduce this with the patch available in the archives:

    $ patch -p1 < v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch 
    patching file doc/src/sgml/ref/reindexdb.sgml
    patching file doc/src/sgml/ref/vacuumdb.sgml
    patching file src/bin/scripts/clusterdb.c
    patching file src/bin/scripts/reindexdb.c
    $ file v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch 
    v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch: unified diff output, ASCII text

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: vacuumdb/clusterdb/reindexdb: allow specifying objects to process in all databases
Next
From: Jacob Champion
Date:
Subject: Re: RFC: logical publication via inheritance root?