harmonize password reuse in vacuumdb, clusterdb, and reindexdb - Mailing list pgsql-hackers

From Nathan Bossart
Subject harmonize password reuse in vacuumdb, clusterdb, and reindexdb
Date
Msg-id 20230628045741.GA1813397@nathanxps13
Whole thread Raw
Responses Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb
List pgsql-hackers
While looking at something unrelated, I noticed that the vacuumdb docs
mention the following:

    vacuumdb might need to connect several times to the PostgreSQL server,
    asking for a password each time.

IIUC this has been fixed since 83dec5a from 2015 (which was superceded by
ff402ae), so I think this note (originally added in e0a77f5 from 2002) can
now be removed.

I also found that neither clusterdb nor reindexdb uses the
allow_password_reuse parameter in connectDatabase(), and the reindexdb
documentation contains the same note about repeatedly asking for a
password (originally added in 85e9a5a from 2005).  IMO we should allow
password reuse for all three programs, and we should remove the
aforementioned notes in the docs, too.  This is what the attached patch
does.

Thoughts?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication
Next
From: Ronan Dunklau
Date:
Subject: Re: Add GUC to tune glibc's malloc implementation.