Re: Add TLI number to name of files generated by pg_waldump --save-fullpage - Mailing list pgsql-hackers

From Kyotaro Horiguchi
Subject Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
Date
Msg-id 20230627.163952.2129200447170879116.horikyota.ntt@gmail.com
Whole thread Raw
In response to Re: Add TLI number to name of files generated by pg_waldump --save-fullpage  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
List pgsql-hackers
At Tue, 27 Jun 2023 15:58:38 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> On Tue, Jun 27, 2023 at 03:44:04PM +0900, Kyotaro Horiguchi wrote:
> > The file name was "LSNh-LSNl.spcOid.dbOid.relNumber.blk_forkname", but
> > the comment in the TAP script read as:
> > 
> > -# XXXXXXXX-XXXXXXXX.DBOID.TLOID.NODEOID.dd_fork with the components being:
> > 
> > which looks wrong. I'm not sure it is a business of this patch, though..
> 
> This part is getting changed here anyway, so improving it is fine by
> me with the terms you are suggesting for these two 4-byte values in
> this comment.

I meant that the name is structured as
TLIh-TLIl.<tablespace>.<database>.<relnumber>.<blk>._<fork>, which
appears to be inconsistent with the comment. (And I'm not sure what
"TLOID" is..)

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Incorrect comment for memset() on pgssHashKey?
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Add TLI number to name of files generated by pg_waldump --save-fullpage