Re: Clean up JumbleQuery() from query text - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Clean up JumbleQuery() from query text
Date
Msg-id 20230626155117.GA1279020@nathanxps13
Whole thread Raw
In response to Clean up JumbleQuery() from query text  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Clean up JumbleQuery() from query text
List pgsql-hackers
On Mon, Jun 26, 2023 at 05:44:49PM +0900, Michael Paquier wrote:
> Joe has reported me offlist that JumbleQuery() includes a dependency
> to the query text, but we don't use that anymore as the query ID is
> generated from the Query structure instead.
> 
> Any thoughts about the cleanup attached?  But at the same time, this
> is simple and a new thing, so I'd rather clean up that now rather than
> later. 

LGTM

> It is not urgent, so I am fine to postpone that after beta2 is
> released on 17~ if there are any objections to that, of course.

Even if extensions are using it, GA for v16 is still a few months away, so
IMO it's okay to apply it to v16.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: ​function arguments are not PG_FUNCTION_ARGS, how to pass Node *escontext
Next
From: Kirk Wolak
Date:
Subject: Re: pgbnech: allow to cancel queries during benchmark