Re: Possible regression setting GUCs on \connect - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Possible regression setting GUCs on \connect
Date
Msg-id 20230427184308.GA1812411@nathanxps13
Whole thread Raw
In response to Re: Possible regression setting GUCs on \connect  (David Steele <david@pgmasters.net>)
Responses Re: Possible regression setting GUCs on \connect  (David Steele <david@pgmasters.net>)
Re: Possible regression setting GUCs on \connect  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
I suspect the problem is that GUCArrayDelete() is using the wrong Datum:

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9dd624b3ae..ee9f87e7f2 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -6496,7 +6496,7 @@ GUCArrayDelete(ArrayType *array, ArrayType **usersetArray, const char *name)
         {
             newarray = construct_array_builtin(&d, 1, TEXTOID);
             if (usersetArray)
-                newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
+                newUsersetArray = construct_array_builtin(&userSetDatum, 1, BOOLOID);
         }
 
         index++;

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: can system catalogs have GIN indexes?
Next
From: David Steele
Date:
Subject: Re: Possible regression setting GUCs on \connect