Re: Add two missing tests in 035_standby_logical_decoding.pl - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Add two missing tests in 035_standby_logical_decoding.pl
Date
Msg-id 20230426102751.pkfs7gwvvrgta6p3@alvherre.pgsql
Whole thread Raw
In response to Re: Add two missing tests in 035_standby_logical_decoding.pl  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
Responses Re: Add two missing tests in 035_standby_logical_decoding.pl
List pgsql-hackers
> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
> index 6f7f4e5de4..819667d42a 100644
> --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
> +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
> @@ -2644,7 +2644,16 @@ sub wait_for_catchup
>      }
>      if (!defined($target_lsn))
>      {
> -        $target_lsn = $self->lsn('write');
> +        my $isrecovery = $self->safe_psql('postgres', "SELECT pg_is_in_recovery()");
> +        chomp($isrecovery);
> +        if ($isrecovery eq 't')
> +        {
> +            $target_lsn = $self->lsn('replay');
> +        }
> +        else
> +        {
> +            $target_lsn = $self->lsn('write');
> +        }

Please modify the function's documentation to account for this code change.


-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Porque Kim no hacía nada, pero, eso sí,
con extraordinario éxito" ("Kim", Kipling)



pgsql-hackers by date:

Previous
From: Jakub Wartak
Date:
Subject: Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns
Next
From: "Zhijie Hou (Fujitsu)"
Date:
Subject: RE: Perform streaming logical transactions by background workers and parallel apply