Postgres Pro
Downloads
Home   >   mailing lists

Re: infobits_set WAL record struct field is int8 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: infobits_set WAL record struct field is int8
Date
Msg-id 20230411204844.lbv2cqn6azepqswh@awork3.anarazel.de
Whole thread Raw
In response to infobits_set WAL record struct field is int8  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: infobits_set WAL record struct field is int8  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Tree view 
Hi,

On 2023-04-11 13:13:49 -0700, Peter Geoghegan wrote:
> Commit 0ac5ad5134 ("Improve concurrency of foreign key locking") added
> infobits_set fields to certain WAL records. However, in the case of
> xl_heap_lock, it made the data type int8 rather than uint8.
>
> I believe that this was a minor oversight. Attached patch fixes the issue.

Makes sense. Looks like there never was a flag defined for the sign bit,
luckily. I assume you're just going to apply this for HEAD?

Greetings,

Andres Freund

pgsql-hackers by date:

Previous
From: Joseph Koshakow
Date:
Subject: Re: is_superuser is not documented
Next
From: Tom Lane
Date:
Subject: Re: Assertion being hit during WAL replay