Hi,
On 2023-03-09 09:36:52 +0900, Michael Paquier wrote:
> On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote:
> > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> >> it's not in ./Makefile ?? Maybe that was for consistency with other
> >> places, or pre-emptive in case the tap tests want to do tests involving
> >> the ZSTD tool. But it'd be better if ./Makefile had it too.
> >
> > I suspect I just over-eagerly added it when the pg_basebackup zstd support
> > went in, using the GZIP_PROGRAM/LZ4 cases as a template. And foolishly
> > assuming a newly added compression method would be tested.
>
> leaving the discussion with the perl warnings aside for the moment,
> these still need to be adjusted. Justin, would you like to write a
> patch with everything you have found?
I now pushed a fix for the two obvious cases pointed out by Justin.
Greetings,
Andres Freund
