Re: meson vs make: missing/inconsistent ENV - Mailing list pgsql-hackers

From Andres Freund
Subject Re: meson vs make: missing/inconsistent ENV
Date
Msg-id 20230226232104.5djexwyitlfemrhg@awork3.anarazel.de
Whole thread Raw
In response to meson vs make: missing/inconsistent ENV  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: meson vs make: missing/inconsistent ENV
Re: meson vs make: missing/inconsistent ENV
List pgsql-hackers
Hi,

On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote:
> I noticed warnings:
> Use of uninitialized value $ENV{"with_icu"} in string eq at
/home/pryzbyj/src/postgres/src/bin/pg_dump/t/002_pg_dump.plline 56.
 
> 
> and looked through: git grep ^export '*/Makefile'
> 
> and found that:
> src/bin/pg_dump/meson.build is missing with_icu since 396d348b0

Looks like it.


> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but
> it's not in ./Makefile ??  Maybe that was for consistency with other
> places, or pre-emptive in case the tap tests want to do tests involving
> the ZSTD tool.  But it'd be better if ./Makefile had it too.

I suspect I just over-eagerly added it when the pg_basebackup zstd support
went in, using the GZIP_PROGRAM/LZ4 cases as a template. And foolishly
assuming a newly added compression method would be tested.


> The rest I think are not errors:
> 
> src/test/meson.build is missing PG_TEST_EXTRA

> src/bin/pg_upgrade/meson.build and ../src/test/recovery/meson.build
> are missing REGRESS_SHLIB

Yep, these are added in the top-level meson.build.


> Is there any consideration of promoting these or other warnings to
> fatal?

You mean the perl warnings?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: "Takamichi Osumi (Fujitsu)"
Date:
Subject: RE: Allow logical replication to copy tables in binary format
Next
From: Tom Lane
Date:
Subject: Re: tests against running server occasionally fail, postgres_fdw & tenk1