Re: BUG #17800: ON CONFLICT DO UPDATE fails to detect incompatible fields that leads to a server crash - Mailing list pgsql-bugs

Hi,

On 2023-02-24 18:49:10 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2023-02-24 17:12:43 -0500, Tom Lane wrote:
> >> I did the renaming you had comments suggesting, but perhaps you want
> >> to bikeshed those names?
> 
> > Not really. I guess it'd be mildly nicer to have Expr somewhere in the name,
> > but whatever.
> 
> Maybe Exec{Create|Push}ExprSetupSteps?

WFM.

> > The "don't bother" comment looks a bit lonely now :)
> 
> I figured it was important to leave a note that that was intentional.
> Doesn't have to look exactly like that, though.

I'd just move it to the the loop evaluating the non resjunk columns.

Greetings,

Andres Freund