Re: Improve logging when using Huge Pages - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Improve logging when using Huge Pages
Date
Msg-id 20230213232245.GI1653@telsasoft.com
Whole thread Raw
In response to Re: Improve logging when using Huge Pages  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Improve logging when using Huge Pages
List pgsql-hackers
On Thu, Feb 09, 2023 at 11:29:09AM -0800, Nathan Bossart wrote:
> On Thu, Feb 09, 2023 at 10:40:13AM +0100, Alvaro Herrera wrote:
> > On 2023-Feb-08, Justin Pryzby wrote:
> >> I don't think it makes sense to run postgres -C huge_pages_active,
> >> however, so I see no issue that that would always returns "false".
> > 
> > Hmm, I would initialize it to return "unknown" rather than "off" — and
> > make sure it turns "off" at the appropriate time.  Otherwise you're just
> > moving the confusion elsewhere.
> 
> I think this approach would address my concerns about using a GUC.

Done that way.  This also fixes the logic in win32_shmem.c.

-- 
Justin

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: [PATCH] Fix unbounded authentication exchanges during PQconnectPoll()
Next
From: Andres Freund
Date:
Subject: Re: recovery modules