Re: run pgindent on a regular basis / scripted manner - Mailing list pgsql-hackers

From Noah Misch
Subject Re: run pgindent on a regular basis / scripted manner
Date
Msg-id 20230204041848.GC1896331@rfd.leadboat.com
Whole thread Raw
In response to Re: run pgindent on a regular basis / scripted manner  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: run pgindent on a regular basis / scripted manner
List pgsql-hackers
On Fri, Feb 03, 2023 at 12:52:50PM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > On 2023-01-22 Su 17:47, Tom Lane wrote:
> >> Yeah.  That's one of my biggest gripes about pgperltidy: if you insert
> >> another assignment in a series of assignments, it is very likely to
> >> reformat all the adjacent assignments because it thinks it's cool to
> >> make all the equal signs line up.  That's just awful.
> 
> > Modern versions of perltidy give you much more control over this, so 
> > maybe we need to investigate the possibility of updating.
> 
> I have no objection to updating perltidy from time to time. I think the
> idea is just to make sure that we have an agreed-on version for everyone
> to use.

Agreed.  If we're changing the indentation of assignments, that's a
considerable diff already.  It would be a good time to absorb other diffs
we'll want eventually, including diffs from a perltidy version upgrade.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add progress reporting to pg_verifybackup
Next
From: "Takamichi Osumi (Fujitsu)"
Date:
Subject: RE: Time delayed LR (WAS Re: logical replication restrictions)