Re: Improve logging when using Huge Pages - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Improve logging when using Huge Pages
Date
Msg-id 20230202155337.gwsjcszhxhdgqmhs@alvherre.pgsql
Whole thread Raw
In response to Re: Improve logging when using Huge Pages  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: Improve logging when using Huge Pages
Re: Improve logging when using Huge Pages
List pgsql-hackers
On 2023-Jan-24, Justin Pryzby wrote:

> On Mon, Jan 23, 2023 at 05:33:35PM -0800, Andres Freund wrote:

> > I'm ok with this being a GUC, it doesn't feel elegant, but I suspect there's
> > no realistic elegant answer.

> Whether it's a GUC or a function, I propose to name it hugepages_active.
> If there's no objections, I'll add to the CF.

Maybe I misread the code (actually I only read the patch), but -- does
it set active=true when huge_pages=on?  I think the code only works when
huge_pages=try.  That might be pretty confusing; I think it should say
"on" in both cases.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Hay dos momentos en la vida de un hombre en los que no debería
especular: cuando puede permitírselo y cuando no puede" (Mark Twain)



pgsql-hackers by date:

Previous
From: Reid Thompson
Date:
Subject: Re: Add the ability to limit the amount of memory that can be allocated to backends.
Next
From: Jeff Davis
Date:
Subject: Re: Move defaults toward ICU in 16?