Re: Using WaitEventSet in the postmaster - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Using WaitEventSet in the postmaster
Date
Msg-id 20221207012224.hjcyzvwdjim22e2a@awork3.anarazel.de
Whole thread Raw
In response to Re: Using WaitEventSet in the postmaster  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Using WaitEventSet in the postmaster  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Hi,

On 2022-12-07 14:12:37 +1300, Thomas Munro wrote:
> On Wed, Dec 7, 2022 at 12:12 PM Andres Freund <andres@anarazel.de> wrote:
> > On 2022-12-07 00:58:06 +1300, Thomas Munro wrote:
> > > One way to fix that for the epoll version is to EPOLL_CTL_DEL and
> > > EPOLL_CTL_ADD, whenever transitioning to/from a zero event mask.
> > > Tried like that in this version.  Another approach would be to
> > > (finally) write DeleteWaitEvent() to do the same thing at a higher
> > > level... seems overkill for this.
> >
> > What about just recreating the WES during crash restart?
> 
> It seems a bit like cheating but yeah that's a super simple solution,
> and removes one patch from the stack.  Done like that in this version.

I somewhat wish we'd do that more aggressively during crash-restart, rather
than the opposite. Mostly around shared memory contents though, so perhaps
that's not that comparable...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Force streaming every change in logical decoding
Next
From: Peter Smith
Date:
Subject: Re: [DOCS] Stats views and functions not in order?