Re: [PATCH] Infinite loop while acquiring new TOAST Oid - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] Infinite loop while acquiring new TOAST Oid
Date
Msg-id 20221128212327.sced62n2sjht46xi@awork3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] Infinite loop while acquiring new TOAST Oid  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Infinite loop while acquiring new TOAST Oid
List pgsql-hackers
Hi,

On 2022-11-28 16:04:12 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > - to
> > combat the space usage we likely should switch to representing the ids as
> > variable width integers or such, otherwise the space increase would likely be
> > prohibitive.
> 
> And I don't buy that either.  An extra 4 bytes with a 2K payload is not
> "prohibitive", it's more like "down in the noise".

The space usage for the the the toast relation + index itself is indeed
irrelevant. Where it's not "down in the noise" is in struct varatt_external,
i.e. references to external toast datums. The size of that already is an
issue.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: fixing CREATEROLE
Next
From: Nikita Malakhov
Date:
Subject: Re: [PATCH] Infinite loop while acquiring new TOAST Oid