Re: Remove a unused argument from qual_is_pushdown_safe - Mailing list pgsql-hackers

From Yugo NAGATA
Subject Re: Remove a unused argument from qual_is_pushdown_safe
Date
Msg-id 20221128165636.141f51e5b3830104d4fe3b86@sraoss.co.jp
Whole thread Raw
In response to Re: Remove a unused argument from qual_is_pushdown_safe  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, 28 Nov 2022 16:40:52 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, Nov 28, 2022 at 11:54:45AM +0900, Michael Paquier wrote:
> > On Fri, Nov 25, 2022 at 04:05:13PM +0800, Richard Guo wrote:
> >> I wonder if we need to revise the comment atop qual_is_pushdown_safe()
> >> too which says
> >> 
> >>  * rinfo is a restriction clause applying to the given subquery (whose RTE
> >>  * has index rti in the parent query).
> >> 
> >> since there is no 'given subquery' after we remove it from the params.
> 
> I was thinking about this point, and it seems to me that we could just
> do s/the given subquery/a subquery/.  But perhaps you have a different
> view on the matter?

+1
I also was just about to send a patch updated as so, and this is attached.

Regards,
Yugo Nagata

> --
> Michael


-- 
Yugo NAGATA <nagata@sraoss.co.jp>

Attachment

pgsql-hackers by date:

Previous
From: Ian Lawrence Barwick
Date:
Subject: Re: Understanding, testing and improving our Windows filesystem code
Next
From: Ian Lawrence Barwick
Date:
Subject: Re: Understanding, testing and improving our Windows filesystem code