Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Resolve partition strategy during early parsing - Mailing list pgsql-committers

From Justin Pryzby
Subject Re: pgsql: Resolve partition strategy during early parsing
Date
Msg-id 20221104161934.GB16921@telsasoft.com
Whole thread Raw
In response to pgsql: Resolve partition strategy during early parsing  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Resolve partition strategy during early parsing
List pgsql-committers
Tree view 
On Thu, Nov 03, 2022 at 03:41:56PM +0000, Alvaro Herrera wrote:
> Resolve partition strategy during early parsing
> 
> This has little practical value, but there's no reason to let the
> partition strategy names travel through DDL as strings.
> 
> Reviewed-by: Japin Li <japinli@hotmail.com>
> Discussion: https://postgr.es/m/20221021093216.ffupd7epy2mytkux@alvherre.pgsql
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/5fca91025e05f803140831953c09a36f08efcef5

This caused a warning in MSVC.

[16:10:46.225] c:\cirrus\src\backend\parser\gram.y(18435) : warning C4715: 'parsePartitionStrategy': not all control
pathsreturn a value
 

I'll send a patch to make cfbot warn about that soon.

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix CREATE DATABASE so we can pg_upgrade DBs with OIDs above 2^3
Next
From: Tom Lane
Date:
Subject: pgsql: First-draft release notes for 15.1.