Re: proposal: possibility to read dumped table's name from file - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: proposal: possibility to read dumped table's name from file
Date
Msg-id 20221104115901.ik2nxbjtxxhbwksk@jrouhaud
Whole thread Raw
In response to Re: proposal: possibility to read dumped table's name from file  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: proposal: possibility to read dumped table's name from file
List pgsql-hackers
On Thu, Nov 03, 2022 at 10:22:15PM +0100, Pavel Stehule wrote:
> čt 3. 11. 2022 v 5:09 odesílatel Julien Rouhaud <rjuju123@gmail.com> napsal:
>
> >
> > Is there any interest with the initial pg_strip_crlf?  AFAICT all the rest
> > of
> > the code will ignore such caracters using isspace() so it wouldn't change
> > anything.
> >
>
> I think reading multiline identifiers is a little bit easier, because I
> don't need to check the ending \n and \r
> When I read multiline identifiers, I cannot ignore white spaces.

Ok.  I don't have a strong objection to it.

>
> updated patch attached
>
> big thanks for these comments and tips

Thanks for the updated patch!  As far as I'm concerned the patch is in a good
shape, passes the CI and I don't have anything more to say so I'm marking it as
Ready for Committer!



pgsql-hackers by date:

Previous
From: Rahila Syed
Date:
Subject: Re: Allow single table VACUUM in transaction block
Next
From: Justin Pryzby
Date:
Subject: Re: proposal: possibility to read dumped table's name from file