Re: GUC values - recommended way to declare the C variables? - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: GUC values - recommended way to declare the C variables?
Date
Msg-id 20221020041559.GJ16921@telsasoft.com
Whole thread Raw
In response to Re: GUC values - recommended way to declare the C variables?  (Peter Smith <smithpb2250@gmail.com>)
List pgsql-hackers
On Thu, Oct 20, 2022 at 11:56:58AM +1100, Peter Smith wrote:
> Patch 0002 adds a sanity-check function called by
> InitializeGUCOptions, as suggested by Tom [2]. This is to ensure that
> the GUC C variable initial values are sensible and/or have not gone
> stale compared with the compiled-in defaults of guc_tables.c. This
> patch also changes some GUC C variable initial values which were
> already found (by this sanity-checker) to be different.

I like it.

However it's fails on windows:

https://cirrus-ci.com/task/5545965036765184

running bootstrap script ... FATAL:  GUC (PGC_BOOL) update_process_title, boot_val=0, C-var=1

Maybe you need to exclude dynamically set gucs ?
See also this other thread, where I added a flag identifying exactly
that.  https://commitfest.postgresql.org/40/3736/
I need to polish that patch some, but maybe it'll be useful for you, too.

-- 
Justin



pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Next
From: Thomas Munro
Date:
Subject: Re: Understanding, testing and improving our Windows filesystem code