Re: use has_privs_of_role() for pg_hba.conf - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: use has_privs_of_role() for pg_hba.conf
Date
Msg-id 20221006174343.GA444656@nathanxps13
Whole thread Raw
In response to Re: use has_privs_of_role() for pg_hba.conf  (Joe Conway <mail@joeconway.com>)
Responses Re: use has_privs_of_role() for pg_hba.conf  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Oct 06, 2022 at 07:33:46AM -0400, Joe Conway wrote:
> On 10/6/22 04:09, Michael Paquier wrote:
>> This patch looks simple, but it is a very sensitive area so I think
>> that we should be really careful.  pg_hba.conf does not have a lot of
>> test coverage, so I'd really prefer if we add something to see the
>> difference of behavior and check the behavior that we are switching
>> here.
> 
> Agreed

Here is a new version of the patch with a test.

>> Joe, you are registered as a reviewer and committer of this patch, by
>> the way.  Are you planning to look at it?
> 
> I am meaning to get to it, but as you say wanted to spend some time to
> understand the nuances and life keeps getting in the way. I will try to
> prioritize it over the next week.

Thanks!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: list of acknowledgments for PG15
Next
From: Vasya
Date:
Subject: [PATCH] Check system cache invalidations before each command in transaction