Postgres Pro
Downloads
Home   >   mailing lists

Re: Enables to call Unregister*XactCallback() in Call*XactCallback() - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Enables to call Unregister*XactCallback() in Call*XactCallback()
Date
Msg-id 20220926221339.GA1344127@nathanxps13
Whole thread Raw
In response to Re: Enables to call Unregister*XactCallback() in Call*XactCallback()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Mon, Sep 26, 2022 at 06:05:34PM -0400, Tom Lane wrote:
> Yeah.  Whether it's efficient or not, seems like it should *work*.
> I'm a bit inclined to call this a bug-fix and backpatch it.
> 
> I went looking for other occurrences of this code in places that have
> an unregister function, and found one in ResourceOwnerReleaseInternal,
> so I think we should fix that too.  Also, a comment seems advisable;
> that leads me to the attached v2.

LGTM.  I have no opinion on back-patching.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Enables to call Unregister*XactCallback() in Call*XactCallback()
Next
From: David Rowley
Date:
Subject: Re: Reducing the chunk header sizes on all memory context types