Re: [BUG] wrong FK constraint name when colliding name on ATTACH - Mailing list pgsql-hackers

From Jehan-Guillaume de Rorthais
Subject Re: [BUG] wrong FK constraint name when colliding name on ATTACH
Date
Msg-id 20220908140716.0323dedd@karst
Whole thread Raw
In response to Re: [BUG] wrong FK constraint name when colliding name on ATTACH  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Thu, 8 Sep 2022 13:25:15 +0200
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> On 2022-Sep-08, Jehan-Guillaume de Rorthais wrote:
> 
> > Hi there,
> > 
> > I believe this very small bug and its fix are really trivial and could be
> > push out of the way quite quickly. It's just about a bad constraint name
> > fixed by moving one assignation after the next one. This could easily be
> > fixed for next round of releases.
> > 
> > Well, I hope I'm not wrong :)  
> 
> I think you're right, so pushed, and backpatched to 12.  I added the
> test case to regression also.

Great, thank you for the additional work on the regression test and the commit!

> For 11, I adjusted the test case so that it didn't depend on an FK
> pointing to a partitioned table (which is not supported there); it turns
> out that the old code is not smart enough to get into the problem in the
> first place.  [...]
> It seems fair to say that this case, with pg11, is unsupported and
> people should upgrade if they want better behavior.

That works for me.

Thanks!



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: ATExecAddColumn() doesn't merge inherited properties
Next
From: Peter Eisentraut
Date:
Subject: list of acknowledgments for PG15