Re: [PATCH] Optimize json_lex_string by batching character copying - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: [PATCH] Optimize json_lex_string by batching character copying
Date
Msg-id 20220831041712.GA640362@nathanxps13
Whole thread Raw
In response to Re: [PATCH] Optimize json_lex_string by batching character copying  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: [PATCH] Optimize json_lex_string by batching character copying
List pgsql-hackers
On Wed, Aug 31, 2022 at 10:50:39AM +0700, John Naylor wrote:
> Here's the final piece. I debated how many tests to add and decided it
> was probably enough to add one each for checking quotes and
> backslashes in the fast path. There is one cosmetic change in the
> code: Before, the vectorized less-equal check compared to 0x1F, but
> the byte-wise path did so with < 32. I made them both "less-equal 31"
> for consistency. I'll commit this by the end of the week unless anyone
> has a better idea about testing.

LGTM

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: effective_multixact_freeze_max_age issue
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15