Re: [RFC] building postgres with meson - v11 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [RFC] building postgres with meson - v11
Date
Msg-id 20220824174248.kuzb7txdnkgytvid@awork3.anarazel.de
Whole thread Raw
In response to Re: [RFC] building postgres with meson - v11  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2022-08-17 14:53:17 -0700, Andres Freund wrote:
> > - In the top-level meson.build, the "renaming" of the Windows system
> >   name
> >
> >       host_system = host_machine.system() == 'windows' ? 'win32' :
> > host_machine.system()
> >       build_system = build_machine.system() == 'windows' ? 'win32' :
> > build_machine.system()
> >
> >   seems unnecessary to me.  Why not stick with the provided names?
> 
> Because right now we also use it for things like choosing the "source" for
> pg_config_os.h (i.e. include/port/{darwin,linux,win32,..}.h). And it seemed
> easier to just have one variable name for all of it.

I am now changing this so that there's an additional 'portname' variable for
this purpose. Otherwise the meson names are used.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Stack overflow issue
Next
From: Nathan Bossart
Date:
Subject: Re: use ARM intrinsics in pg_lfind32() where available