Re: Schema variables - new implementation for Postgres 15 - Mailing list pgsql-hackers

From Justin Pryzby
Subject Re: Schema variables - new implementation for Postgres 15
Date
Msg-id 20220724190959.GF7789@telsasoft.com
Whole thread Raw
In response to Re: Schema variables - new implementation for Postgres 15  (Erik Rijkers <er@xs4all.nl>)
List pgsql-hackers
Hi Erik,

On Sun, Jul 24, 2022 at 03:39:32PM +0200, Erik Rijkers wrote:
> Attached a few small text-changes.

When you send patches like this, could you rename them to something other than
*.patch and *.diff ?

Otherwise, cfbot tries to apply *only* your patches to master, which fails due
to missing the original patches that your changes are on top of, and makes it
look like the author's patch needs to be rebased.
http://cfbot.cputube.org/pavel-stehule.html - Apply patches: FAILED

Alternately, (especially if your patch fixes a bug), you can resend the
author's patches, rebased, as [1.patch, ..., N.patch] plus your changes as
N+1.patch.  Then, cfbot tests your patches, and the author can easily review
and then integrate your changes.  (This is especially nice if the patches
currently need to be rebased, and you can make the cfbot pass at the same time
as sending fixes).

Cheers,

-- 
Justin



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: ReadRecentBuffer() is broken for local buffer
Next
From: Noah Misch
Date:
Subject: Re: fairywren hung in pg_basebackup tests