Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH v1] eliminate duplicate code in table.c - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH v1] eliminate duplicate code in table.c
Date
Msg-id 20220721121824.2tbsgjxqczzopncl@alvherre.pgsql
Whole thread Raw
In response to [PATCH v1] eliminate duplicate code in table.c  (Junwang Zhao <zhjwpku@gmail.com>)
Responses Re: [PATCH v1] eliminate duplicate code in table.c
List pgsql-hackers
Tree view 
On 2022-Jul-21, Junwang Zhao wrote:

> There are some duplicate code in table.c, add a static inline function
> to eliminate the duplicates.

Hmm, but see commit 2ed532ee8c47 about this kind of check.  Perhaps we
should change these error messages to conform to the same message style.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I love the Postgres community. It's all about doing things _properly_. :-)"
(David Garamond)

pgsql-hackers by date:

Previous
From: Bilal Yavuz
Date:
Subject: Re: [RFC] building postgres with meson - v10
Next
From: Dean Rasheed
Date:
Subject: Re: [PATCH] Introduce array_shuffle() and array_sample()