Re: automatically generating node support functions - Mailing list pgsql-hackers

From Andres Freund
Subject Re: automatically generating node support functions
Date
Msg-id 20220711202646.ognbado7uwed3ojj@awork3.anarazel.de
Whole thread Raw
In response to Re: automatically generating node support functions  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: automatically generating node support functions
List pgsql-hackers
Hi,

On 2022-07-11 16:17:28 -0400, Robert Haas wrote:
> On Mon, Jul 11, 2022 at 3:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > We can't simply move the file list into gen_node_support.pl, because
> > (a) the build system has to know about the dependencies involved, and
> > (b) gen_node_support.pl wouldn't know what to do in VPATH situations.
> > However, we could have gen_node_support.pl contain a canonical list
> > of the files it expects to be handed, and make it bitch if its
> > arguments don't match that.
> 
> Sorry if I'm being dense, but why do we have to duplicate the list of
> files instead of having gen_node_support.pl just sort whatever list
> the build system provides to it?

Because right now there's two buildsystems already (look at
Solution.pm). Looks like we'll briefly have three, then two again.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Next
From: Tom Lane
Date:
Subject: Re: automatically generating node support functions