Re: Probable memory leak with ECPG and AIX - Mailing list pgsql-hackers

From Noah Misch
Subject Re: Probable memory leak with ECPG and AIX
Date
Msg-id 20220703034346.GC2378460@rfd.leadboat.com
Whole thread Raw
In response to Re: Probable memory leak with ECPG and AIX  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Probable memory leak with ECPG and AIX
List pgsql-hackers
On Sat, Jul 02, 2022 at 11:37:08PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Thanks for reviewing.  Pushed with that comment.  prairiedog complains[1]:
> >   ld: common symbols not allowed with MH_DYLIB output format with the -multi_module option
> >   connect.o definition of common _ecpg_clocale (size 4)
> 
> Blah.
> 
> > I bet this would fix it:
> 
> > -locale_t    ecpg_clocale;
> > +locale_t    ecpg_clocale = (locale_t) 0;
> 
> Hmm, I was considering suggesting that just on stylistic grounds,
> but decided it was too nitpicky even for me.
> Do you want me to test it on prairiedog?

Sure, if it's easy enough.  If not, I'm 87% sure it will suffice.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Probable memory leak with ECPG and AIX
Next
From: Tom Lane
Date:
Subject: Re: Probable memory leak with ECPG and AIX