Postgres Pro
Downloads
Home   >   mailing lists

Re: refactor some protocol message sending in walsender and basebackup - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: refactor some protocol message sending in walsender and basebackup
Date
Msg-id 20220701213646.GA582729@nathanxps13
Whole thread Raw
In response to refactor some protocol message sending in walsender and basebackup  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: refactor some protocol message sending in walsender and basebackup
List pgsql-hackers
Tree view 
On Thu, Jun 23, 2022 at 04:36:36PM +0200, Peter Eisentraut wrote:
> Some places in walsender.c and basebackup_copy.c open-code the sending of
> RowDescription and DataRow protocol messages.  But there are already more
> compact and robust solutions available for this, using DestRemoteSimple and
> associated machinery, already in use in walsender.c.
> 
> The attached patches 0001 and 0002 are tiny bug fixes I found during this.
> 
> Patches 0003 and 0004 are the main refactorings.  They should probably be
> combined into one patch eventually, but this way the treatment of
> RowDescription and DataRow is presented separately.

All 4 patches look reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Use outerPlanState macro instead of referring to leffttree
Next
From: Nathan Bossart
Date:
Subject: Re: pg_checkpointer is not a verb or verb phrase