Postgres Pro
Downloads
Home   >   mailing lists

Re: Extension pg_trgm, permissions and pg_dump order - Mailing list pgsql-bugs

From Nathan Bossart
Subject Re: Extension pg_trgm, permissions and pg_dump order
Date
Msg-id 20220621175616.GA93985@nathanxps13
Whole thread Raw
In response to Re: Extension pg_trgm, permissions and pg_dump order  (Noah Misch <noah@leadboat.com>)
Responses Re: Extension pg_trgm, permissions and pg_dump order
List pgsql-bugs
Tree view 
On Wed, Jun 15, 2022 at 10:42:18PM -0700, Noah Misch wrote:
> -REGRESS = citext citext_utf8
> +REGRESS = create_index_acl citext citext_utf8

It's a little unfortunate that these tests are located within the citext
module, but I can't claim to have a better idea.

> +         * Identify the opclass to use.  Use of ddl_userid is necessary due to
> +         * ACL checks therein.  This is safe despite opclasses containing
> +         * opaque expressions (specifically, functions), because only
> +         * superusers can define opclasses.

It's not clear to me why the fact that only superusers can define opclasses
makes this safe.

Overall, the patch seems reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

pgsql-bugs by date:

Previous
From: Amit Kapila
Date:
Subject: Re: BUG #17524: Increase in WAL size due to logical replication with publication contain a table with low activity.
Next
From: Jacob Champion
Date:
Subject: Re: BUG #17522: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL test fails on OpenBSD 7.1