Re: Proposal: adding a better description in psql command about large objects - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Proposal: adding a better description in psql command about large objects
Date
Msg-id 20220603172911.GA2671189@nathanxps13
Whole thread Raw
In response to Re: Proposal: adding a better description in psql command about large objects  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jun 03, 2022 at 12:56:20PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> Another option could be to move it after the "Input/Output" section so that
>> it's closer to some other commands that involve files.  I can't say I have
>> a strong opinion about whether/where to move it, though.
> 
> Yeah, I thought of that choice too, but it ends up placing the
> Large Objects section higher up the list than seems warranted on
> frequency-of-use grounds.

Fair point.

> After looking at the output I concluded that we'd be better off to
> stick with the normal indentation amount, and break the lo_import
> entry into two lines to make that work.  One reason for this is
> that some translators might've already settled on a different
> indentation amount in order to cope with translated parameter names,
> and deviating from the normal here will just complicate their lives.
> So that leaves me proposing v5.

I see.  As you noted earlier, moving the entries higher makes the
inconsistent indentation less appealing, too.  So this LGTM.

> (I also fixed the out-of-date line count in helpVariables.)

Yeah, it looks like 7844c99 missed this.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: adding a better description in psql command about large objects
Next
From: Jeremy Schneider
Date:
Subject: Re: Collation version tracking for macOS