Re: Assert name/short_desc to prevent SHOW ALL segfault - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Assert name/short_desc to prevent SHOW ALL segfault
Date
Msg-id 20220527174317.GA1650647@nathanxps13
Whole thread Raw
In response to Re: Assert name/short_desc to prevent SHOW ALL segfault  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Assert name/short_desc to prevent SHOW ALL segfault
List pgsql-hackers
On Thu, May 26, 2022 at 11:01:44PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> FWIW, I would be fine to backpatch the NULL handling for short_desc,
>> while treating the addition of nonnull as a HEAD-only change.
> 
> Yeah, sounds about right to me.  My guess is that we will need
> a configure check for nonnull, but perhaps I'm wrong.

Makes sense.  Here's a new patch set.  0001 is the part intended for
back-patching, and 0002 is the rest (i.e., adding pg_attribute_nonnull()).
I switched to using __has_attribute to discover whether nonnull was
supported, as that seemed cleaner.  I didn't see any need for a new
configure check, but maybe I am missing something.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Support logical replication of DDLs
Next
From: Peter Geoghegan
Date:
Subject: Re: suboverflowed subtransactions concurrency performance optimize