Re: Add --{no-,}bypassrls flags to createuser - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Add --{no-,}bypassrls flags to createuser
Date
Msg-id 20220523163735.GA938919@nathanxps13
Whole thread Raw
In response to Re: Add --{no-,}bypassrls flags to createuser  (Shinya Kato <Shinya11.Kato@oss.nttdata.com>)
Responses Re: Add --{no-,}bypassrls flags to createuser
List pgsql-hackers
On Mon, May 23, 2022 at 11:55:43PM +0900, Shinya Kato wrote:
> On 2022-05-23 16:29, Michael Paquier wrote:
>> May I ask for the addition of tests when one specifies multiple
>> switches for --admin and --member?  This would check the code path
>> where you build a list of role names.  You could check fancier string
>> patterns, while on it, to look after the use of fmtId(), say with
>> role names that include whitespaces or such.
> 
> Thanks!
> I changed to the test that describes multiple "-m".
> It seems to be working without any problems, how about it?

Michael also requested a test for multiple -a switches and for fancier
string patterns.  Once that is taken care of, I think this can be marked as
ready-for-committer.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Zheng Li
Date:
Subject: Re: Support logical replication of DDLs
Next
From: Nathan Bossart
Date:
Subject: Re: docs: mention "pg_read_all_stats" in "track_activities" description