Re: failures in t/031_recovery_conflict.pl on CI - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: failures in t/031_recovery_conflict.pl on CI
Date
Msg-id 202205030746.pfpbpywy7xp7@alvherre.pgsql
Whole thread Raw
In response to Re: failures in t/031_recovery_conflict.pl on CI  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2022-May-02, Andres Freund wrote:

> > > pgindent uses some crazy formatting nearby:
> > >         SendRecoveryConflictWithBufferPin(
> > >                                           PROCSIG_RECOVERY_CONFLICT_STARTUP_DEADLOCK);
> > 
> > I do not believe that that line break is pgindent's fault.
> 
> Oh - I'm fairly certain I've seen pgindent do that in the past. But you're
> right, it's not. Perhaps it was an older version of pgindent?

No, it's never done that.  We used to fold lines that way manually,
because pgindent used to push the argument to the left, but that changed
at commit 382ceffdf7f6.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria.  Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Perform streaming logical transactions by background workers and parallel apply
Next
From: Alvaro Herrera
Date:
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL