On Thu, Apr 07, 2022 at 08:39:58PM +0900, Masahiko Sawada wrote:
> On Thu, Apr 7, 2022 at 7:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Thu, Apr 7, 2022 at 8:25 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > I'll take care of this today. I think we can mark the new function
> > > get_column_offset() being introduced by this patch as parallel safe.
> >
> > Pushed.
>
> Thanks!
I took a closer look at the test case. The "get_column_offset(coltypes) % 8"
part would have caught the problem only when run on an ALIGNOF_DOUBLE==4
platform. Instead of testing the start of the typalign='d' column, let's test
the first offset beyond the previous column. The difference between those two
values depends on ALIGNOF_DOUBLE. While there, ignore typbyval; it doesn't
affect disk tuple layout, so this test shouldn't care. I plan to push the
attached patch.
