Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date
Msg-id 20220406192915.GZ10577@tamriel.snowman.net
Whole thread Raw
In response to Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Greetings,

* Laurenz Albe (laurenz.albe@cybertec.at) wrote:
> On Tue, 2022-04-05 at 13:06 -0700, Nathan Bossart wrote:
> > On Tue, Apr 05, 2022 at 11:25:36AM -0400, Stephen Frost wrote:
> > > Please find attached an updated patch + commit message.  Mostly, I just
> > > went through and did a bit more in terms of updating the documentation
> > > and improving the comments (there were some places that were still
> > > worrying about the chance of a 'stray' backup_label file existing, which
> > > isn't possible any longer), along with some additional testing and
> > > review.  This is looking pretty good to me, but other thoughts are
> > > certainly welcome.  Otherwise, I'm hoping to commit this tomorrow.
> >
> > LGTM!
>
> Cassandra (not the software) from the sidelines predicts that we will
> get some fire from users for this, although I concede the theoretical
> sanity of the change.

Great, thanks for that.

This has now been committed- thanks again to everyone for their help!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: shared-memory based stats collector - v70
Next
From: Justin Pryzby
Date:
Subject: Re: shared-memory based stats collector - v70