Re: shared-memory based stats collector - v66 - Mailing list pgsql-hackers

From Andres Freund
Subject Re: shared-memory based stats collector - v66
Date
Msg-id 20220402082102.ojdd2e6cobsmljvh@alap3.anarazel.de
Whole thread Raw
In response to Re: shared-memory based stats collector - v66  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-hackers
Hi,

On 2022-03-25 17:24:18 +0900, Kyotaro Horiguchi wrote:
> > * AFIXME: Should all the stats drop code be moved into pgstat_drop.c?
> 
> Or pgstat_xact.c?

I wasn't initially happy with that suggestion, but after running with it, it
looks pretty good.

I also moved a fair bit of code into pgstat_shm.c, which to me improved code
navigation a lot. I'm wondering about splitting it further even, into
pgstat_shm.c and pgstat_entry.c.

What do you think?

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: shared-memory based stats collector - v66
Next
From: John Naylor
Date:
Subject: Re: A qsort template