Re: pg_stat_get_replication_slot() marked not strict, crashes - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg_stat_get_replication_slot() marked not strict, crashes
Date
Msg-id 20220328045412.dqxvmnywmnkpizvp@alap3.anarazel.de
Whole thread Raw
In response to Re: pg_stat_get_replication_slot() marked not strict, crashes  (Andres Freund <andres@anarazel.de>)
Responses Re: pg_stat_get_replication_slot() marked not strict, crashes  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,

On 2022-03-27 21:09:29 -0700, Andres Freund wrote:
> FWIW, I have a test for both, I was a bit "stuck" on where to put the
> pg_stat_get_subscription_stats(NULL) test. I had put the
> pg_stat_get_replication_slot(NULL) in contrib/test_decoding/sql/stats.sql
> but pg_stat_get_subscription_stats() doesn't really fit there.  I think I'm
> coming down to putting a section of such tests into src/test/regress/sql/stats.sql
> instead. In the hope of preventing future such occurrances by encouraging
> people to copy the test...

Pushed with tests there.

Vignesh, thanks for the patches! I already had something locally, should have
mentioned that...

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: pg_stat_get_replication_slot() marked not strict, crashes
Next
From: Amit Kapila
Date:
Subject: Re: logical decoding and replication of sequences