Re: Pointer subtraction with a null pointer - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Pointer subtraction with a null pointer
Date
Msg-id 20220326184147.dhkoghv52kkfrpi4@alap3.anarazel.de
Whole thread Raw
In response to Re: Pointer subtraction with a null pointer  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Pointer subtraction with a null pointer
List pgsql-hackers
Hi,

On 2022-03-26 14:13:56 -0400, Tom Lane wrote:
> The attached also silences the warning, and getting rid of the double-eval
> hazard seems like a net win.

Looks good wrt relptr_store. Maybe we should fix the double-eval hazard in
relptr_access too, think that'd be only one left over...


> > Might also be worth adding an assertion that base < val.
> 
> Did that too.  On the whole I like this better.

Better than the relptr_store_null() approach I assume? Agreed, if so.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Next
From: Tom Lane
Date:
Subject: Why is lorikeet so unstable in v14 branch only?