Re: MDAM techniques and Index Skip Scan patch - Mailing list pgsql-hackers

From Dmitry Dolgov
Subject Re: MDAM techniques and Index Skip Scan patch
Date
Msg-id 20220322200008.yadxrrr6n3pbj4qp@erthalion.local
Whole thread Raw
In response to Re: MDAM techniques and Index Skip Scan patch  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
> On Mon, Mar 21, 2022 at 06:34:09PM -0700, Andres Freund wrote:
>
> > I don't mind having all of the alternatives under the same CF item, only
> > one being tested seems to be only a small limitation of cfbot.
>
> IMO it's pretty clear that having "duelling" patches below one CF entry is a
> bad idea. I think they should be split, with inactive approaches marked as
> returned with feeback or whatnot.

On the other hand even for patches with dependencies (i.e. the patch A
depends on the patch B) different CF items cause a lot of confusion for
reviewers. I guess for various flavours of the same patch it would be
even worse. But I don't have a strong opinion here.

> Either way, currently this patch fails on cfbot due to a new GUC:
> https://api.cirrus-ci.com/v1/artifact/task/5134905372835840/log/src/test/recovery/tmp_check/regression.diffs
> https://cirrus-ci.com/task/5134905372835840

This seems to be easy to solve.

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Column Filtering in Logical Replication
Next
From: Thomas Munro
Date:
Subject: Re: MDAM techniques and Index Skip Scan patch