Re: Issue with pg_stat_subscription_stats - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Issue with pg_stat_subscription_stats
Date
Msg-id 20220312201517.vt4vk6nstxmwslgf@alap3.anarazel.de
Whole thread Raw
In response to Re: Issue with pg_stat_subscription_stats  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Issue with pg_stat_subscription_stats
Re: Issue with pg_stat_subscription_stats
List pgsql-hackers
Hi,

On 2022-03-12 08:28:35 +0530, Amit Kapila wrote:
> On Sat, Mar 12, 2022 at 2:14 AM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
> >
> > So, I noticed that pg_stat_reset_subscription_stats() wasn't working
> > properly, and, upon further investigation, I'm not sure the view
> > pg_stat_subscription_stats is being properly populated.
> >
> 
> I have tried the below scenario based on this:
> Step:1 Create some data that generates conflicts and lead to apply
> failures and then check in the view:

I think the problem is present when there was *no* conflict
previously. Because nothing populates the stats entry without an error, the
reset doesn't have anything to set the stats_reset field in, which then means
that the stats_reset field is NULL even though stats have been reset.

I'll just repeat what I've said before: Making variable numbered stats
individiually resettable is a bad idea.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option
Next
From: Nathan Bossart
Date:
Subject: Re: Add index scan progress to pg_stat_progress_vacuum