Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal
Date
Msg-id 20220227115526.vhpfhlinbruax5ky@jrouhaud
Whole thread Raw
In response to pg_stat_statements: remove redundant function call in pg_stat_statements_internal  (Dong Wook Lee <sh95119@gmail.com>)
Responses Re: pg_stat_statements: remove redundant function call in pg_stat_statements_internal  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
Hi,

On Sun, Feb 27, 2022 at 08:45:13PM +0900, Dong Wook Lee wrote:
> 
> I found some redundant function calls in
> pg_stat_statements.c/pg_stat_statements_internal(),
> There is no need to call GetUserId() again because the value was
> previously obtained.

Indeed.  I doubt it will make any real difference but it doesn't hurt to fix
it.

Patch looks good to me.

pgsql-hackers by date:

Previous
From: Dong Wook Lee
Date:
Subject: pg_stat_statements: remove redundant function call in pg_stat_statements_internal
Next
From: Michael Paquier
Date:
Subject: Re: PATCH: add "--config-file=" option to pg_rewind