Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
Date
Msg-id 202201291937.nqkjelodukvu@alvherre.pgsql
Whole thread Raw
In response to Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Remove extra includes of "access/xloginsert.h" when "access/xlog.h" is included
List pgsql-hackers
On 2022-Jan-29, Bharath Rupireddy wrote:

> Removing the xloginsert.h in xlog.h would need us to add xloginsert.h
> in more areas.

Sure.

> And also, it might break any non-core extensions that
> includes just xlog.h and gets xloginsert.h.

That's a pretty easy fix anyway -- it's not even version-specific, since
the fix would work with the older versions.  It's not something that
would break on a minor version, either.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                                                           (Paul Graham)



pgsql-hackers by date:

Previous
From: Dmitry Dolgov
Date:
Subject: Re: Multiple Query IDs for a rewritten parse tree
Next
From: James Coleman
Date:
Subject: Re: Add last commit LSN to pg_last_committed_xact()