Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f) - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f)
Date
Msg-id 20220117001043.hgjci4zqt3l4susa@jrouhaud
Whole thread Raw
In response to Re: default to to ON_ERROR_STOP=on (Re: psql: exit status with multiple -c and -f)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On Mon, Dec 27, 2021 at 12:31:07PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > I think the current behavior of the regression test SQL scripts is exactly the
> > opposite of what's desirable for almost all other scripts.  The attached makes
> > ON_ERROR_STOP the default, and runs the regression tests with ON_ERROR_STOP=0.
> 
> > Is it viable to consider changing this ?
> 
> I don't think so.  The number of scripts you will break is far greater
> than the number whose behavior will be improved, because people who
> wanted this behavior will already be selecting it.  Maybe this wasn't
> the greatest choice of default, but it's about twenty years too late
> to change it.
> 
> I'd also note that I see a fairly direct parallel to "set -e" in
> shell scripts, which is likewise not the default.
> 
> We could consider documentation changes to make this issue
> more visible, perhaps.  Not sure what would be a good place.

I'm marking the CF entry as returned with feedback as it's been a few weeks
without proposal for documentation change.



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: extended stats on partitioned tables
Next
From: Peter Geoghegan
Date:
Subject: Time to increase hash_mem_multiplier default?