Re: Some RELKIND macro refactoring - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Some RELKIND macro refactoring
Date
Msg-id 202111231536.b56wwkvlg2m7@alvherre.pgsql
Whole thread Raw
In response to Re: Some RELKIND macro refactoring  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On 2021-Nov-23, Alvaro Herrera wrote:

> On 2021-Nov-22, Peter Eisentraut wrote:
> 
> > Maybe
> > 
> >     else
> >     {
> >         Assert(RELKIND_HAS_STORAGE(rel->rd_rel->relkind);
> >         RelationCreateStorage(rel->rd_node, relpersistence);
> >     }
> > 
> > create_storage is set earlier based on RELKIND_HAS_STORAGE(), so this would
> > be consistent.
> 
> Hmm, right ... but I think we can make this a little simpler.  How about
> the attached?

This doesn't actually work, so nevermind that.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
Essentially, you're proposing Kevlar shoes as a solution for the problem
that you want to walk around carrying a loaded gun aimed at your foot.
(Tom Lane)



pgsql-hackers by date:

Previous
From: "Drouvot, Bertrand"
Date:
Subject: Re: Patch to avoid orphaned dependencies
Next
From: Aleksander Alekseev
Date:
Subject: Re: ResourceOwner refactoring