Re: pgsql: Fix headerscheck failure in replication/worker_internal.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date
Msg-id 202111161709.u3pbx5lxdimt@alvherre.pgsql
Whole thread Raw
Responses Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
List pgsql-hackers
On 2021-Nov-16, Alvaro Herrera wrote:

> Fix headerscheck failure in replication/worker_internal.h

The other failure is in src/include/libpq/be-gssapi-common.h:

In file included from /tmp/headerscheck.a6f0um/test.c:2:
./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No existe el fichero o el directorio
   20 | #include <gssapi/gssapi.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.

One possible solution for this one is to add an exclusion in
headerscheck (and cpluspluscheck?); the other possible solution seems to
be to wrap the whole contents of the file in "#ifdef ENABLE_GSS".  I
think the latter is roughly the approach used for OpenSSL inclusions.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs
Next
From: Stephen Frost
Date:
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h