Re: Removed unused import modules from tap tests - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Removed unused import modules from tap tests
Date
Msg-id 202111101237.xzlr2edsns5e@alvherre.pgsql
Whole thread Raw
In response to Re: Removed unused import modules from tap tests  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Removed unused import modules from tap tests
Re: Removed unused import modules from tap tests
List pgsql-hackers
On 2021-Nov-10, Michael Paquier wrote:

> I would not have bothered changing things if the names of the modules
> were the same across stable branches to minimize merge conflicts.
> 
> However, everything has changed on HEAD, so there is a good argument
> for simplifying the tests as you are proposing here.  Any thoughts
> from others?

I agree with your reasoning, but I wonder what's the *benefit* of
removing those includes.  IOW, what's the reason not to simply drop the
patch?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Next
From: Michael Paquier
Date:
Subject: Re: Commitfest 2021-11 Patch Triage - Part 2