Re: [PATCH] Proposal for HIDDEN/INVISIBLE column - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Date
Msg-id 202110182036.pkngfqfxb57p@alvherre.pgsql
Whole thread Raw
In response to [PATCH] Proposal for HIDDEN/INVISIBLE column  (Gilles Darold <gilles@migops.com>)
Responses Re: [PATCH] Proposal for HIDDEN/INVISIBLE column  (Gilles Darold <gilles@migops.com>)
List pgsql-hackers
On 2021-Oct-18, Gilles Darold wrote:

> Le 18/10/2021 à 18:54, Alvaro Herrera a écrit :
> > I suggest to look for output test files that are being massively
> > modified by this patch.  I think those are likely unintended:
> >
> >> diff --git a/src/test/regress/expected/collate.icu.utf8.out b/src/test/regress/expected/collate.icu.utf8.out
> >> diff --git a/src/test/regress/expected/collate.linux.utf8.out b/src/test/regress/expected/collate.linux.utf8.out
> >> diff --git a/src/test/regress/expected/compression.out b/src/test/regress/expected/compression.out
> >> diff --git a/src/test/regress/expected/xml.out b/src/test/regress/expected/xml.out
> >> diff --git a/src/test/regress/expected/xmlmap.out b/src/test/regress/expected/xmlmap.out
> 
> My bad, thanks for the report Alvaro. New patch version v3 should fix that.

Hmm, the attachment was 500kB before, about 30% of that was the
collate.*.out files, and it is 2.2 MB now.  Something is still not
right.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Porque francamente, si para saber manejarse a uno mismo hubiera que
rendir examen... ¿Quién es el machito que tendría carnet?"  (Mafalda)



pgsql-hackers by date:

Previous
From: Gilles Darold
Date:
Subject: Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Next
From: "Bossart, Nathan"
Date:
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable