Re: pgsql: Document XLOG_INCLUDE_XID a little better - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Document XLOG_INCLUDE_XID a little better
Date
Msg-id 202110021440.hepk6kcgtjzi@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Document XLOG_INCLUDE_XID a little better  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: pgsql: Document XLOG_INCLUDE_XID a little better
List pgsql-hackers
On 2021-Oct-02, Dilip Kumar wrote:

> I have written two patches, Approach1 is as you described using a
> static boolean and Approach2 as a local variable to XLogAssembleRecord
> as described by Amit, attached both of them for your reference.
> IMHO, either of these approaches looks cleaner.

Thanks!  I haven't read these patches carefully, but I think the
variable is about assigning the *subxid*, not the topxid.  Amit can
confirm ...


-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio)



pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option
Next
From: Tom Lane
Date:
Subject: Re: 2021-09 Commitfest